fix: fix synthetic lifecycle for mixed API versions and non-portals #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
May 30, 2024
| // See issue #4242 for details. | ||
| monkeyPatchDomAPIs(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not totally happy with this solution, but I couldn't come up with something better for now. Perhaps in the future we can figure out a better way to have the engine-dom monkey-patches handoff to the engine-core monkey-patches.
On the bright side, this only affects dev mode.
nolanlawson
commented
May 30, 2024
| }, | ||
| }; | ||
|
|
||
| const plugins = [customLwcRollupPlugin]; |
There was a problem hiding this comment.
We probably should have had something like this from the get-go; we need a way to test components with mixed API versions.
nolanlawson
commented
May 30, 2024
| await Promise.resolve(); | ||
|
|
||
| // It should render even though it's inserted manually | ||
| expect(extractDataIds(apiVersion60Elm).h1.textContent).toEqual('API version 60!'); |
There was a problem hiding this comment.
This fails without the fix, and it only fails in dev mode.
ekashida
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4242.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
In dev mode, synthetic lifecycle will actually work for lazy components inside of non-portals now.
GUS work item
W-15812405