Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add front end validation for tags #114

Merged
merged 1 commit into from
Nov 28, 2016
Merged

add front end validation for tags #114

merged 1 commit into from
Nov 28, 2016

Conversation

annyhe
Copy link
Contributor

@annyhe annyhe commented Nov 28, 2016

improved error message for invalid input

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.763% when pulling 1236dd0 on stopInvalidTagOnWrite into b678ebd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.763% when pulling 70e7a54 on stopInvalidTagOnWrite into b678ebd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.763% when pulling aa4d720 on stopInvalidTagOnWrite into b678ebd on master.

@annyhe
Copy link
Contributor Author

annyhe commented Nov 28, 2016 •
edited
Loading

I tried creating a review app but ran into problems when connecting to redis. @meynet can you create a review app and share the url? I can push subjects and aspects data to it.
Here is what it should look like on invalid input on update:
screen shot 2016-11-27 at 7 47 33 pm
On create:
screen shot 2016-11-27 at 7 48 30 pm

iamigo
iamigo previously requested changes Nov 28, 2016
View reviewed changes
Copy link
Contributor

@iamigo iamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding all these tests and all the lint-checking stuff!!!

view/admin/components/pages/Detail.js
this.setState({ error: '' });
}
// obj contains invalid fields and their data
setIinvalidFieldObj(invalidFieldObj) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in function name?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.763% when pulling 18392ca on stopInvalidTagOnWrite into b678ebd on master.

@shriramshankar shriramshankar merged commit c67e0f3 into master Nov 28, 2016
annyhe added a commit that referenced this pull request Nov 29, 2016
@annyhe
Revert "add front end validation for tags (#114)"
1d4a1cd 
This reverts commit c67e0f3.
iamigo pushed a commit that referenced this pull request Nov 29, 2016
@annyhe @iamigo
Revert "add front end validation for tags (#114)" (#116)
0aa6a3c 
This reverts commit c67e0f3.
annyhe added a commit that referenced this pull request Nov 30, 2016
@annyhe
Revert "Revert "add front end validation for tags (#114)" (#116)"
824ca32 
This reverts commit 0aa6a3c.
shriramshankar pushed a commit that referenced this pull request Nov 30, 2016
@annyhe @shriramshankar
Revert "Revert "add front end validation for tags (#114)" (#116)" (#118)
83a5346 
This reverts commit 0aa6a3c.
pallavi2209 pushed a commit that referenced this pull request Dec 1, 2016
@annyhe @pallavi2209
Revert "Revert "add front end validation for tags (#114)" (#116)" (#118)
d8ce323 
This reverts commit 0aa6a3c.
@shriramshankar shriramshankar deleted the stopInvalidTagOnWrite branch January 13, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamigo iamigo iamigo approved these changes

Assignees

@iamigo iamigo

@pallavi2209 pallavi2209

@shriramshankar shriramshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annyhe @coveralls @iamigo @pallavi2209 @shriramshankar