GET Bot Data api #452
Merged
GET Bot Data api #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavi2209
reviewed
Jul 27, 2017
| done(err); | ||
| } | ||
|
|
||
| expect(res.body.length).to.equal(ONE); |
There was a problem hiding this comment.
Do you intend to check the contents here as well? Or that implementation is still pending?
pallavi2209
reviewed
Jul 27, 2017
api/v1/controllers/botData.js
Outdated
| * @param {Function} next - The next middleware function in the stack | ||
| */ | ||
| findRoomBotBotData(req, res, next) { | ||
| doFind(req, res, next, helper); |
There was a problem hiding this comment.
I am confused. Do you intend to update the doFind logic for roomIds and botIds or is it already in place?
|
will not review until tests passing |
iamigo
approved these changes
Jul 28, 2017
* master: DELETE BotData API (#457) # Conflicts: # api/v1/controllers/botData.js # api/v1/helpers/nouns/botData.js
shriramshankar
approved these changes
Jul 31, 2017
|
@tausifmuzaffar Some conflicts to resolve here. |
* master: PATCH BotData (#454) # Conflicts: # api/v1/controllers/botData.js # api/v1/helpers/nouns/botData.js # api/v1/swagger.yaml
tausifmuzaffar
added a commit
that referenced
this pull request
Aug 1, 2017
* master: GET Bot Data api (#452) # Conflicts: # api/v1/controllers/botData.js # api/v1/helpers/nouns/botData.js # api/v1/swagger.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/botData
/botData/key
/rooms/key/data
/rooms/key/bot/key/data