-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#Refocus api token database updates #97
Conversation
name: { | ||
type: dataTypes.STRING(constants.fieldlen.normalName), | ||
allowNull: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a name field ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a user has multiple tokens, the name field makes it possible to identify a particular token one might wish to disable or delete
type: dataTypes.STRING, | ||
allowNull: false, | ||
unique: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamigo @pallavi2209 Any thoughts on having a default values for all the data types? We might be able to get ride of the responsify function at one point of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shriram can you create a spike for team to discuss this? (But let's not let it hold up this particular PR.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will approve after fixing reference to lens/lenses
}, | ||
}, | ||
name: { | ||
singular: 'Lens', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
a5ac0eb
to
652ed73
Compare
@iamigo @shriramshankar updated the PR. |
New Model: Token
Columns:
Indexes:
Associations:
Scopes:
Hooks:
Permissions: