-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug: previously clicking cancel on admin details page opens edit panel #98
Conversation
910d902
to
1e33650
Compare
Review app at http://refocus-pr-91.herokuapp.com//subjects/Salesforce.SFDC_Core.WAX.SPX.NA21. |
@@ -65,6 +65,7 @@ | |||
"connect-redis": "^3.0.2", | |||
"cookie-parser": "^1.4.1", | |||
"debug": "^2.2.0", | |||
"enzyme": "^2.6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meynet license ok for this new external dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamigo @meynet Enzyme uses MIT license. https://www.npmjs.com/package/enzyme
@annyhe When I go to http://refocus-pr-91.herokuapp.com/subjects/Salesforce.SFDC_Core.WAX.SPX.CS33 and click Add child, then cancel, I am redirected to subject list page. Is that expected? |
I'm ok with having it like it is for right now--it's a UI design question we should let Jee decide when she gets to it. |
@pallavi2209 Yes that is the expected behavior, and identical to the UI on the master. |
906d426
to
a5ab098
Compare
Why enzyme?
vs. TestUtils verbose props.children...props.children
http://brewhouse.io/2016/03/18/accelerate-your-react-testing-with-enzyme.html
https://medium.com/airbnb-engineering/enzyme-javascript-testing-utilities-for-react-a417e5e5090f#.xyjupa296