Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: previously clicking cancel on admin details page opens edit panel #98

Merged
merged 3 commits into from
Nov 15, 2016

Conversation

annyhe
Copy link
Contributor

@annyhe annyhe commented Nov 13, 2016

  • fix UI bug
  • add tests to show bug is fixed
  • introduce airbnb enzyme to react unit testing.

Why enzyme?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.951% when pulling 1e33650 on cancelsProperly into c8424e5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.951% when pulling 1e33650 on cancelsProperly into c8424e5 on master.

@annyhe annyhe changed the title fix bug: previously clicking cancel on admin UI opens edit panel fix bug: previously clicking cancel on admin details page opens edit panel Nov 13, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.951% when pulling 1e33650 on cancelsProperly into c8424e5 on master.

@annyhe
Copy link
Contributor Author

annyhe commented Nov 13, 2016

Review app at http://refocus-pr-91.herokuapp.com//subjects/Salesforce.SFDC_Core.WAX.SPX.NA21.
Click on the cancel button on Delete modal, or the x on upper left, to close the Delete modal.

@@ -65,6 +65,7 @@
"connect-redis": "^3.0.2",
"cookie-parser": "^1.4.1",
"debug": "^2.2.0",
"enzyme": "^2.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meynet license ok for this new external dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pallavi2209
Copy link
Contributor

@annyhe When I go to http://refocus-pr-91.herokuapp.com/subjects/Salesforce.SFDC_Core.WAX.SPX.CS33 and click Add child, then cancel, I am redirected to subject list page. Is that expected?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.951% when pulling 906d426 on cancelsProperly into 4df2b8f on master.

@iamigo
Copy link
Contributor

iamigo commented Nov 14, 2016

When I go to http://refocus-pr-91.herokuapp.com/subjects/Salesforce.SFDC_Core.WAX.SPX.CS33 and click Add child, then cancel, I am redirected to subject list page. Is that expected?

I'm ok with having it like it is for right now--it's a UI design question we should let Jee decide when she gets to it.

@annyhe
Copy link
Contributor Author

annyhe commented Nov 14, 2016

@pallavi2209 Yes that is the expected behavior, and identical to the UI on the master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.951% when pulling a5ab098 on cancelsProperly into 2337cc5 on master.

@pallavi2209 pallavi2209 merged commit e23c5a9 into master Nov 15, 2016
@pallavi2209 pallavi2209 deleted the cancelsProperly branch November 15, 2016 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants