Skip to content

fix: remove uncaughtException listner / refactor messages file to match command name #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2024
Merged

fix: remove uncaughtException listner / refactor messages file to match command name #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3980c65
fix: remove uncaughtException listner / refactor messages file to mat…
WillieRuemmele Jun 3, 2024
b7796f3
chore: update error handling to not overwrite our errors
WillieRuemmele Jun 4, 2024
8b002b7
chore: remove try/catch
WillieRuemmele Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 messages/report.md → messages/gettest.md
View file
Open in desktop
File renamed without changes.
7 changes: 1 addition & 6 deletions src/commands/apex/get/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { RunResult, TestReporter } from '../../../reporters/index.js';
import { resultFormat } from '../../../utils.js';

Messages.importMessagesDirectoryFromMetaUrl(import.meta.url);
const messages = Messages.loadMessages('@salesforce/plugin-apex', 'report');
const messages = Messages.loadMessages('@salesforce/plugin-apex', 'gettest');
export default class Test extends SfCommand<RunResult> {
public static readonly summary = messages.getMessage('summary');
public static readonly description = messages.getMessage('description');
Expand Down Expand Up @@ -65,11 +65,6 @@ export default class Test extends SfCommand<RunResult> {
public async run(): Promise<RunResult> {
const { flags } = await this.parse(Test);

// add listener for errors
process.on('uncaughtException', (err) => {
throw messages.createError('apexLibErr', [err.message]);
});

const conn = flags['target-org'].getConnection(flags['api-version']);

const testService = new TestService(conn);
Expand Down
6 changes: 0 additions & 6 deletions src/commands/apex/run/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
} from '@salesforce/sf-plugins-core';
import { Messages, SfError } from '@salesforce/core';
import { Duration } from '@salesforce/kit';

import { RunResult, TestReporter } from '../../../reporters/index.js';
import { resultFormat } from '../../../utils.js';

Expand Down Expand Up @@ -122,11 +121,6 @@ export default class Test extends SfCommand<RunCommandResult> {
flags['test-level'] as TestLevel
);

// add listener for errors
process.on('uncaughtException', (err) => {
throw messages.createError('apexLibErr', [err.message]);
});

// graceful shutdown
const exitHandler = async (): Promise<void> => {
await this.cancellationTokenSource.asyncCancel();
Expand Down