Skip to content

W-16449818 feat: use @oclif/multi-stage-output #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 21, 2024
Merged

W-16449818 feat: use @oclif/multi-stage-output #1123

merged 17 commits into from
Aug 21, 2024

Conversation

mdonnalley
Copy link
Collaborator

@mdonnalley mdonnalley commented Aug 8, 2024 •
edited
Loading

What does this PR do?

Use new @oclif/multi-stage-output for

  • project delete source
  • project deploy start
  • project deploy resume
  • project deploy validate
  • project deploy report
  • project retrieve start

sf project deploy start

happy path

Screen.Recording.2024-08-08.at.11.17.40.AM.mov

happy path with tests

Screen.Recording.2024-08-08.at.11.18.56.AM.mov

async

Screen.Recording.2024-08-08.at.11.20.27.AM.mov

CI

Screen.Recording.2024-08-08.at.11.21.17.AM.mov

concurrent deploys causes pending status

Screen.Recording.2024-08-08.at.11.53.13.AM.mov

client timeout

client-timeout.mov

canceled deploy

Screen.Recording.2024-08-08.at.11.59.26.AM.mov

source conflicts

Screen.Recording.2024-08-08.at.12.47.42.PM.mov

sf project retrieve start

happy path

Screen.Recording.2024-08-08.at.12.01.30.PM.mov

CI

Screen.Recording.2024-08-08.at.12.02.40.PM.mov

source conflicts

Screen.Recording.2024-08-08.at.12.43.59.PM.mov

What issues does this PR fix or reference?

@W-16449818@

@mdonnalley mdonnalley requested a review from a team as a code owner August 8, 2024 18:03
@WillieRuemmele
Copy link
Contributor

QA Notes

✅ : all of the videos posted look great
✅ : checked project delete source
✅ : deploy with invalid apex
💡 : for @VivekMChawla - only show errors/issues in the table, remove success table for a cleaner output
✅ : resume

@WillieRuemmele WillieRuemmele merged commit c4f1cff into main Aug 21, 2024
@WillieRuemmele WillieRuemmele deleted the mdonnalley/ink branch August 21, 2024 20:23
mdonnalley added a commit that referenced this pull request Aug 26, 2024
@mdonnalley
Revert "Merge pull request #1123 from salesforcecli/mdonnalley/ink"
0a2a582 
This reverts commit c4f1cff, reversing
changes made to 2098219.
mdonnalley added a commit that referenced this pull request Aug 26, 2024
@mdonnalley
fix: revert MSO changes (#1147)
afb625e 
* Revert "fix: prevent NaN in stage output (#1139)"

This reverts commit e426bf5.

* Revert "Merge pull request #1123 from salesforcecli/mdonnalley/ink"

This reverts commit c4f1cff, reversing
changes made to 2098219.
mdonnalley pushed a commit that referenced this pull request Sep 4, 2024
@WillieRuemmele @mdonnalley
Merge pull request #1123 from salesforcecli/mdonnalley/ink
8ed9430 
feat: use @oclif/multi-stage-output
@iowillhoit iowillhoit changed the title feat: use @oclif/multi-stage-output W-16449818 feat: use @oclif/multi-stage-output Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdonnalley @WillieRuemmele