W-17909761 - feat: confirm agent delete #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Mar 14, 2025
| @@ -189,6 +191,29 @@ export class Source extends SfCommand<DeleteSourceJson> { | |||
| fsPaths: await getPackageDirs(), | |||
| include: this.componentSet, | |||
| }); | |||
| // Confirm if the user wants to delete GenAiPlugins as part of an agent | |||
| if (!this.flags['no-prompt']) { | |||
There was a problem hiding this comment.
so if --no-prompt it will delete all genAiFuncs?
There was a problem hiding this comment.
No, only GenAiPlugins. GenAiFuncs are not included in the delete.
QA Noteswith SDR branch built/linked✅ : choose all agents, see all topics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When deleting by agent pseudo type, ask the user which topics (genAiPlugins) related to the agent that they'd like to delete. Topics can be used by multiple agents so developers might not want to delete them with the agent metadata.
What issues does this PR fix or reference?
@W-17909761@