feat: establish valid experience site sessions at startup #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrkruk
changed the title
nrkruk
changed the title
nrkruk
changed the title
kmbauer
reviewed
Sep 20, 2024
| import fs from 'node:fs'; | ||
| import path from 'node:path'; | ||
| import { Org, SfError } from '@salesforce/core'; | ||
| import axios from 'axios'; |
There was a problem hiding this comment.
Is there a reason we used axios over native node fetch (just curious).
There was a problem hiding this comment.
not really, it was just a little easier to get working initially. Axios has some nice extra features that help with debugging like interceptors. But yeah I could switch over to using fetch I guess
kmbauer
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On local-dev startup, simulate the auth flow for establishing a valid SID token for sites via servlets (
/servlet/networks/switch). Grab the valid token from those requests and append to any proxied requests back to core for the life of the local development session. Requests in the browser may still show asGuest=true but be proxied to your org with valid authentication credentials by the dev server.Create a new environment variable
SITE_GUEST_ACCESS. When set to true, this will skip attempting to establish a valid authentication session at startup and allow you to access the site as a guest user.Note: This is more of a temporary solution to support sites auth and may evolve as we update the Beta and work towards GA
What issues does this PR fix or reference?
@W-16647027@