You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Free up the $config property name for connector subclasses
#559
This conflicts with Saloon’s inherited property, even though consumers generally only need the public config() method and should not need to interact with its backing store directly.
Would you consider making the backing property private or renaming it to something internal, such as $requestConfig or $saloonConfig?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Saloon’s
HasConfigtrait currently declares a protected$configproperty:Because
Connectoruses this trait, connector implementations cannot use$configfor their own typed configuration:This conflicts with Saloon’s inherited property, even though consumers generally only need the public
config()method and should not need to interact with its backing store directly.Would you consider making the backing property private or renaming it to something internal, such as
$requestConfigor$saloonConfig?The public
config()API could remain unchanged while freeing the common$configproperty name for connector and request implementations.I understand that changing a protected property may require a major release if direct subclass access is considered supported.
For now, I’m using
$optionsfor my connector’s configuration object to avoid conflicting with Saloon’s protected$configproperty.All reactions