Consistent list order #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadard
reviewed
Nov 4, 2019
hadard
reviewed
Nov 5, 2019
| ) | ||
| const arrayPropertyToSort = sortFieldInfo.fieldsToSortHierarchy.pop() as string | ||
| fieldsToSort.forEach(field => { | ||
| field[arrayPropertyToSort] = _.orderBy( |
There was a problem hiding this comment.
To support order of lists of primitives
field[arrayPropertyToSort] = _.orderBy(
field[arrayPropertyToSort],
sortFieldInfo.fieldToSortBy ? sortFieldInfo.fieldToSortBy : undefined
)
There was a problem hiding this comment.
Added another method as the object structure is entirely different
added 2 commits
November 5, 2019 14:05
hadard
reviewed
Nov 5, 2019
| return | ||
| } | ||
| // const sortInfo = _.clone(sortFieldInfo) | ||
| instancesToChange.forEach(elem => { |
There was a problem hiding this comment.
not sure I understand the content of the forEach, I think we can just do:
instancesToChange.forEach(elem => {
const path = fieldsToSortHierarchy.join('.') // IMO we can also put in SortField path instead of building it
const sorted = _.orderBy(_.get(elem.value, path), sortFieldInfo.fieldToSortBy)
_.set(elem.value, path, sorted)
})
am I missing something?
There was a problem hiding this comment.
Your suggestion doesn't work.
Also, added comments inline, to explain the logic.
There was a problem hiding this comment.
weird, I don't understand why... if you have time I'll be happy to look on it together. Anyway approving this.
added 2 commits
November 6, 2019 01:17
hadard
approved these changes
Nov 6, 2019
| return | ||
| } | ||
| // const sortInfo = _.clone(sortFieldInfo) | ||
| instancesToChange.forEach(elem => { |
There was a problem hiding this comment.
weird, I don't understand why... if you have time I'll be happy to look on it together. Anyway approving this.
orendig
added a commit
that referenced
this pull request
Nov 6, 2019
* Added settings filter * End help message with EOL (#340) * removed extension readme badges (#345) * fixes command title (#339) * added event listener to file changes in extension (#338) * added error severity in extension (#344) * added error severity in extension * changed event filter out non-bp file changes (#341) * added wrapper to run aggr set function (fixes SALTO-264) (#342) * try #1 to fix Capriza failure: "TypeError: Cannot read property 'lookupFilter' of undefined" (#346) * SALTO-218: apply changes from state to bps post deploy (#343) * Replaced async-file package (#347) * upgraded inquirer.js to fix hang in Windows 10 * moved accesses to fs module to centralized file module * using tmp-promise instead of tmp * change default fetch behavior to auto approve incoming changes (#350) * Added settings filter * Hadar CR * Consistent list order (#348) List ordering for specific ObjectTypes and records (InstanceElements) * missing await in apply changes post deploy (#356) * added missing await in fetch (#353) * Consistent list order (#348) List ordering for specific ObjectTypes and records (InstanceElements) * missing await in apply changes post deploy (#356) * Added settings filter * Hadar CR * add debug logs (#355) * blacklisted static resources (#352) * shouldn't add default ObjectType annotations upon adapter.update (#357) * Hadar comments * rename elemId fieldType name to field_name since it collides with a Custom object that named Name and it causes undesired merge of the ObjectTypes (#354) * Fixed e2e * Fixed e2e * Added settings filter * Hadar CR * Hadar comments * Fixed e2e * Fixed e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List ordering for ObjectTypes and records (InstanceElements)