states/file.prepend: fixes #32915 define file header verbatim, in inp… #33270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m, in input order
| @@ -3945,7 +3945,8 @@ def prepend(name, | |||
| sources=None, | |||
| source_hashes=None, | |||
| defaults=None, | |||
| context=None): | |||
| context=None, | |||
| header=None): | |||
There was a problem hiding this comment.
We need to add documentation to the docstring of this function to explain what this does, please.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
May 20, 2016
* upstream/develop: revved latest to 2015.8.9, added note regarding Mint Linux to 2015.8.9 release notes Event assert (saltstack#33262) Catch exception raised from invalid verify_options (saltstack#33317) states/file.prepend: fixes saltstack#32915 define file header verbatim, in inp… (saltstack#33270) Add support for kapacitor 0.13 (saltstack#33352) verify_socket: show what interface:port is in error; DRY refactoring (saltstack#33320) Eliminate dry-run false positives for files in /tmp (saltstack#33344) refs#33348: fix ret status code for state.sls_id (saltstack#33349) adding the () to make changes work (saltstack#33337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds a new boolean to states/file.py def prepend which makes the outcome of this state arguably more intuitive.
What issues does this PR fix or reference?
This address #32915
Previous Behavior
The user could define text to be prepended to a file, but lines which already occurred elsewhere in the file were not prepended. This led to predictable, but unexpected results.
New Behavior
The user is able to use a new kwarg boolean to state that (s)he wants to have the input appear exactly as entered, at the very top of the target file.
Tests written?
No. But developed through manual test runs.