Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dry-run false positives for files in /tmp #33344

Merged
merged 1 commit into from
May 19, 2016
Merged

Eliminate dry-run false positives for files in /tmp #33344

merged 1 commit into from
May 19, 2016

Conversation

eradman
Copy link
Contributor

@eradman eradman commented May 18, 2016

What does this PR do?

Eliminates false positives for crontab ownership when running state.highstate
with test=True

What issues does this PR fix or reference?

Previous Behavior

vm:
----------
          ID: system_tasks
    Function: cron.file
        Name: salt://vm/root.cron
      Result: None
     Comment: The following values are set to be changed:
              group: crontab
     Started: 14:46:49.708843
    Duration: 101.032 ms
     Changes:   

Summary for vm
-------------
Succeeded: 22 (unchanged=1)
Failed:     0
-------------

New Behavior

vm:

Summary for vm
-------------
Succeeded: 22
Failed:     0
-------------

Tests written?

No

@eradman
Eliminate dry-run false positives for files in /tmp
5372391 
cron.file() writes the crontab out to a temporary file before comparing
with the source. Asserting file ownership and permissions in this
context creates sometimes false positives.

This change does not affect highstate without test=True
@cachedout cachedout merged commit 9cd9cf6 into saltstack:develop May 19, 2016
@eradman eradman deleted the dry_run branch May 19, 2016 16:48
gitebra pushed a commit to gitebra/salt that referenced this pull request May 20, 2016
@jojohans
Merge remote-tracking branch 'upstream/develop' into develop
e0a9275 
* upstream/develop:
  revved latest to 2015.8.9, added note regarding Mint Linux to 2015.8.9 release notes
  Event assert (saltstack#33262)
  Catch exception raised from invalid verify_options (saltstack#33317)
  states/file.prepend: fixes saltstack#32915 define file header verbatim, in inp… (saltstack#33270)
  Add support for kapacitor 0.13 (saltstack#33352)
  verify_socket: show what interface:port is in error; DRY refactoring (saltstack#33320)
  Eliminate dry-run false positives for files in /tmp (saltstack#33344)
  refs#33348: fix ret status code for state.sls_id (saltstack#33349)
  adding the () to make changes work (saltstack#33337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eradman @cachedout