unit tests for rpm.checksum() and zypper.download() #33501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @meaksh Minor lint issue here: https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/2085/violations/file/tests/unit/modules/rpm_test.py/ Thanks |
|
@meaksh Don't use Vi. Vi is a Roman number. And Vi Vi Vi is a number of Beast. You cannot edit files with a numbers. Use Emacs! 😆 (on identation) |
|
Hi @cachedout and @isbm Lint issue fixed. Thank you! :) BTW, I like Iron Maiden, that's why I use Vi... 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR provides unit tests for
rpm.checksumandzypper.downloadTests written?
Yes
/cc @isbm