Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum validation for zypper pkg.download in 2016.3 and develop #35269

Conversation

meaksh
Copy link
Contributor

@meaksh meaksh commented Aug 8, 2016

What does this PR do?

This PR brings some missing changes related with PRs #33469 and #33501 to the 2016.3 and develop branches.

Seems PRs were merged in 2015.8 but for some conflicts (a5e0141) not all changes were merged forward to 2016.3 and develop. I don't know if there was a reason to avoid some of the changes, so I create this PR.

This PR enables checksum validation for pkg.download in zypper execution module.

Tests written?

Yes

Could you please take a look?
Thanks!

/cc @isbm

@isbm
Copy link
Contributor

isbm commented Aug 8, 2016

@meaksh thanks adding that back. No idea how it got lost in between merges though.
@cachedout LGTM 👍

@cachedout cachedout merged commit c58bb18 into saltstack:2016.3 Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants