modules.slack.post_message: Allow sending messages to direct-message … #34983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eliasp Looks good. Could you just fix one little lint warning? https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/3669/violations/file/salt/modules/slack_notify.py/ Then we'll get this in. Thanks. |
…channels (name starting with @)
eliasp
force-pushed
the
2016.3-salt.modules.slack-allow-sending-dms
branch
from
a531f2f
to
fe0952a
Compare
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It enables
salt.modules.slack.post_messageto also send messages to personal/direct-message channels whose name doesn't start with#but@instead.What issues does this PR fix or reference?
none
Previous Behavior
The message never arrived in the desired channel, although the module reported success (which is another issue I'm going to fix) as it converted a channel name like
@eliaspto#@eliasp.New Behavior
It accepts now a channel name like
@eliaspand only prepends a#as a fallback in case the channel name neither starts with@nor#.Tests written?
No