failhard not being respected in batch/orch #54701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
Oloremo
commented
Sep 20, 2019
| failhard | ||
| pass failhard down to the executing state | ||
|
|
||
| .. versionadded:: 2019.2.2 |
There was a problem hiding this comment.
not sure if I need to set versions in this PR
Oloremo
force-pushed
the
failhard-batch-fix
branch
2 times, most recently
from
0ed0592
to
0ee6d07
Compare
Oloremo
force-pushed
the
failhard-batch-fix
branch
from
0ee6d07
to
ae78644
Compare
|
re-run full all |
|
2019.2 code base seems unstable. Made PR for 2019.2.1 branch: #54806 |
|
Closed in favor of #54806 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added proper detection of
failhardduring the orchestration\batch logic.This is backport of the #54700, huge thanks to @mattp- for the original patch.
What issues does this PR fix or reference?
#54521
Previous Behavior
batch didn't stop upon encountering the error with
failhardset toTrueNew Behavior
batch stops upon encountering the error with
failhardset toTrueTests written?
Yes
Commits signed with GPG?
Yes