Skip to content

Error page not following baseurl #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ninja- opened this issue Nov 17, 2014 · 8 comments
Closed

Error page not following baseurl #205

ninja- opened this issue Nov 17, 2014 · 8 comments

Comments

@ninja-
Copy link

ninja- commented Nov 17, 2014

Example error page:

<!DOCTYPE html>
<html>
<head>
  <title>The change you wanted was rejected (422)</title>
  <link href="**BASE URL SHOULD GO HERE**/static.css" media="screen" rel="stylesheet" type="text/css" />
</head>

<body>
  <!-- This file lives in public/422.html -->
  <h1>422</h1>
  <div>
    <h2>The change you wanted was rejected.</h2>
    <p>Maybe you tried to change something you didn't have access to.</p>
  </div>
</body>
</html>

Small bug...
/static.css doesn't follow baseurl, causing not found error.
@sameersbn
Copy link
Owner

@ninja- what is this?

@ninja-
Copy link
Author

ninja- commented Nov 17, 2014

That was an example error page(don't mind the actual error).
I am referring to /static.css which is missing baseurl.

@sameersbn
Copy link
Owner

@ninja- which file is this?

@ninja-
Copy link
Author

ninja- commented Nov 17, 2014

/home/git/gitlab/public/*.html

@sameersbn
Copy link
Owner

@ninja- in my local install

$ cat /home/git/gitlab/public/422.html 
<!DOCTYPE html>
<html>
<head>
  <title>The change you wanted was rejected (422)</title>
  <link href="/static.css" media="screen" rel="stylesheet" type="text/css" />
</head>

<body>
  <!-- This file lives in public/422.html -->
  <h1>422</h1>
  <div>
    <h2>The change you wanted was rejected.</h2>
    <p>Maybe you tried to change something you didn't have access to.</p>
  </div>
</body>
</html>

@sameersbn
Copy link
Owner

@ninja- if you think it is not correct, please open an issue with the upstream gitlab project.

@ninja-
Copy link
Author

ninja- commented Nov 17, 2014

I still think these files should be patched based on GITLAB_RELATIVE_URL_ROOT...

@sameersbn
Copy link
Owner

Support for configuring gitlab at relative_url is supported and
documented by upstream gitlab. Editing the error templates is not part
of this configuration.

If you do think this is an error, you should open an issue request with
the upstream gitlab project.

On Monday 17 November 2014 03:18 PM, ninja- wrote:

I still think these files should be patched based on
GITLAB_RELATIVE_URL_ROOT...

—
Reply to this email directly or view it on GitHub
#205 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sameersbn @ninja-