Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiplatform build (add arm support) #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siberianlove
Copy link
Contributor

Based on issue #510

Since used base image (ruby) has arm support it's pretty easy to add arm support here too. Setup QEMU and specify supported platforms.

Tested on my m1 machine:

изображение

Not only through docker cli, but ui is working fine too.

For debugging i published image on my docker hub account through my fork of this repo. You can check it too if you want to:
https://hub.docker.com/r/siberianlove/redmine/tags

@frank-dspeed
Copy link
Collaborator

It is a good thing in general but as far as i know i need to recheck we would maybe need a total other image name for arm images will look into that the change in general is correct. i Only need to verify that with docker hub that efficent tagging would be possible @sameersbn maybe look also into that do we want to publish multi arch?

@jcormier
Copy link
Collaborator

jcormier commented Jun 4, 2024

@siberianlove, I had looked at this last year and started adding support but at the time the blocker was the base ubuntu image and getting certain packages installed. As you mention with the ruby image this suddenly gets very easy to do.

Your changes look look good to me and the github auto checks had no issues building it which is comforting.

I think the only thing missing is an update to the README and a arm64 specific docker compose file for testing. At the time I had written the following document update though if you could update it and make sure it works that's be nice.

Could you grab and update if needed the following commits:
6bb9ca8
d8829bc -- ignore the mysql8 update, I think that needs to be done separately and with some care.

@jcormier
Copy link
Collaborator

jcormier commented Jun 4, 2024

@frank-dspeed, from my previous research i do believe this should work as written for docker hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants