Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAM: "next" vs "next primary". #44

Open
jkbonfield opened this issue Sep 30, 2014 · 2 comments
Open

SAM: "next" vs "next primary". #44

jkbonfield opened this issue Sep 30, 2014 · 2 comments
Labels

Comments

@jkbonfield
Copy link
Contributor

For RNEXT and PNEXT fields we explicitly state the next primary alignment. It is a bit unclear what the interpretation of these fields on a secondary alignment, but that's not a big issue.

For FLAG field the 0x8 and 0x20 bits mention "next segment" with no qualification of it being the next primary segment. Clearly we need primary data as if we are looking at the first read in a pair then we use FLAG, RNEXT and PNEXT jointly to obtain information about the "other end". If RNEXT/PNEXT refer to the other end but FLAG may potentially not then these fields lose their usefulness.

I believe the table of bits in 1.4 should be modified as s/next segment/next primary segment/;

@nh13
Copy link
Member

nh13 commented Dec 10, 2014

This would also align with changes we have made in supporting CRAM.

@jkbonfield
Copy link
Contributor Author

See also #53 for a more detailed commentary on this.

It is my current feeling that while there is an ambiguity between PNEXT/RNEXT and FLAG regarding primary vs non-primary attributes, the whole concept needs a revision and we should permit RNEXT/PNEXT/TLEN for self-consistent secondary mappings too.

Either way FLAG has to be one of the places the text is changed as it is part and parcel of the pnext/plen/tlen/flag quadvector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants