Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checks for pthread calls on FreeBSD #68

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

jkbonfield
Copy link
Collaborator

Implemented an AX_SEARCH_LIBS_REV function as a minimal replacement of AC_SEARCH_LIBS but with the no-library case as the last thing to try. This solves the problem where we preferentially want an external library implementation over the built-in C library.

Addresses autoconf issue raised in #64

@jmarshall
Copy link
Member

On my FreeBSD/arm64 VM, ./configure produced

…
checking for function pthread_join... -lpthread
…

and make produced well-linked test executables that worked. However if thr is going to be listed, I guess ideally it would be selected on FreeBSD where it exists… (On this FreeBSD/arm64 machine, libpthread.so etc are just symlinks to libthr.*.)

@jkbonfield
Copy link
Collaborator Author

jkbonfield commented Oct 20, 2022

Ok fair enough. Trivial to switch them around. (And thanks for the testing)

Implemented an AX_SEARCH_LIBS_REV function as a minimal replacement of
AC_SEARCH_LIBS but with the no-library case as the last thing to try.
This solves the problem where we preferentially want an external
library implementation over the built-in C library.

Addresses autoconf issue raised in samtools#64
@jkbonfield jkbonfield merged commit 5414de5 into samtools:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants