Update Vault and IIIF type defs. #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewjordan
force-pushed
the
2854-update-vault
branch
from
6312d68
to
779362f
Compare
mathewjordan
force-pushed
the
2854-update-vault
branch
from
779362f
to
96791a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR gets Clover off of the old
@hyperion-frameworkand use the newer@iiif/vaultand@iiif/presentation-3packages instead. Some logic required updating throughout due to soome small changes during the package extraction/migration to IIIF Commons. See https://github.com/IIIF-Commons/vault/#changes-to-hyperion-vault for that.Otherwise, things should be functioning pretty much the same. All manifests that previously rendered seem to be loading and rendering as expected. Let me know if you see otherwise.