Prefetch related solr documents and then lazily convert to SpeedyAF proxy objects #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mason Ballengee <masaball@iu.edu>
masaball
reviewed
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For objects with a large number of related child or parent objects SpeedyAF's lazy approach can result in hundreds or thousands of solr queries for individual documents. This PR figures out what all of these will be and fetches all of the documents in one solr request. It sets attributes on the proxy object with the pre-fetched solr documents then when a relation is later accessed it will cast it into a proxy object. For a show view of a particular object in production Avalon at IU these changes reduce the amount of time spent in solr requests from about 30s to about 0.5s.