Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveFedora::Base.find should cast by default #223

Closed
jeremyf opened this issue Sep 24, 2013 · 0 comments
Closed

ActiveFedora::Base.find should cast by default #223

jeremyf opened this issue Sep 24, 2013 · 0 comments
Assignees
@jeremyf

Comments

@jeremyf
Copy link
Contributor

jeremyf commented Sep 24, 2013

Given that we often do AF.find(pid, cast: true), we should assume that parameter. It would also tidy up the API and bring it closer inline to ActiveRecord.

Don't forget to deprecate the existing behavior of not casting unless specified
@ghost ghost assigned jeremyf Sep 24, 2013
jeremyf added a commit that referenced this issue Sep 24, 2013
@jeremyf
Deprecate .find's cast default option
39ac485 
By default ActiveFedora::Base.find assumes cast to be false. This pull
request deprecates that behavior

Related #223
@jeremyf jeremyf mentioned this issue Sep 24, 2013
Closed
jeremyf added a commit that referenced this issue Sep 24, 2013
@jeremyf
Deprecate .find's cast default option
20927b8 
By default ActiveFedora::Base.find assumes cast to be false. This pull
request deprecates that behavior

Related #223
@jeremyf jeremyf mentioned this issue Sep 24, 2013
Merged
jcoyne added a commit that referenced this issue Sep 24, 2013
@jcoyne
Merge pull request #225 from projecthydra/gh-223
c6d64e5 
Switch find's cast to default as true
@jcoyne jcoyne closed this as completed Oct 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremyf jeremyf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremyf @jcoyne