♻️ Favor Hyku::Application.path_for over Rails.root #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the existence of Knapsack we need to consider how overrides in Knapsack will take precedence over Hyku files. This change handles cases where we want to use the Knapsack's uploaded thumbnails. Related to: - #2010
kirkkwang
approved these changes
Oct 5, 2023
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 9, 2023
This is now obviated by upstream Hyku. Prior to this commit, we were looking in `Rails.root` but we needed to first interogate the Knapsack and then Rails.root. Related to: - samvera/hyku#2010 - samvera/hyku#2012 - #60 - samvera-labs/hyku_knapsack#1
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 10, 2023
This is now obviated by upstream Hyku. Prior to this commit, we were looking in `Rails.root` but we needed to first interogate the Knapsack and then Rails.root. Related to: - samvera/hyku#2010 - samvera/hyku#2012 - #60 - samvera-labs/hyku_knapsack#1
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the existence of Knapsack we need to consider how overrides in Knapsack will take precedence over Hyku files. This change handles cases where we want to use the Knapsack's uploaded thumbnails.
Related to: