🐛 Fix Add to Collection for page 2+ of works #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, when you were on page 2 of your works and selected a work to add to a collection, the query for available collections would use the page 2 as part of the collection query. This would mean the first 100 collections (default page size) that you had access to add works to were skipped. With this commit, we omit the query parameters from the works page and then query collections. Related to: - samvera/hyrax#5972 - samvera/hyrax#5969 - https://github.com/scientist-softserv/adventist-dl/issues/625 Co-authored-by: LaRita Robinson <larita@scientist.com>
laritakr
approved these changes
Oct 13, 2023
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 13, 2023
This includes: - samvera/hyku#2023 > 🐛 Fix Add to Collection for page 2+ of works > > Prior to this commit, when you were on page 2 of your works and selected > a work to add to a collection, the query for available collections would > use the page 2 as part of the collection query. This would mean the > first 100 collections (default page size) that you had access to add > works to were skipped. > > With this commit, we omit the query parameters from the works page and > then query collections. > > Related to: > > - samvera/hyrax#5972 > - samvera/hyrax#5969 > - https://github.com/scientist-softserv/adventist-dl/issues/625 Co-authored-by: LaRita Robinson <larita@scientist.com>
jeremyf
added a commit
to scientist-softserv/adventist_knapsack
that referenced
this pull request
Oct 16, 2023
This includes: - samvera/hyku#2023 > 🐛 Fix Add to Collection for page 2+ of works > > Prior to this commit, when you were on page 2 of your works and selected > a work to add to a collection, the query for available collections would > use the page 2 as part of the collection query. This would mean the > first 100 collections (default page size) that you had access to add > works to were skipped. > > With this commit, we omit the query parameters from the works page and > then query collections. > > Related to: > > - samvera/hyrax#5972 > - samvera/hyrax#5969 > - https://github.com/scientist-softserv/adventist-dl/issues/625 Co-authored-by: LaRita Robinson <larita@scientist.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, when you were on page 2 of your works and selected
a work to add to a collection, the query for available collections would
use the page 2 as part of the collection query. This would mean the
first 100 collections (default page size) that you had access to add
works to were skipped.
With this commit, we omit the query parameters from the works page and
then query collections.
Related to:
Co-authored-by: LaRita Robinson larita@scientist.com