Remove to_param implementation that was just used in unit tests #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This override was here in the first place because the default implementation of to_param in ActiveModel requires the object to be persisted. We should fix this upstream: samvera/active_fedora#1251
revgum
approved these changes
May 26, 2017
mjgiarlo
added a commit
to samvera/hyku
that referenced
this pull request
Jun 2, 2017
sephirothkod
pushed a commit
to UVicLibrary/Vault
that referenced
this pull request
Jul 13, 2017
sephirothkod
added a commit
to UVicLibrary/Vault
that referenced
this pull request
Jul 13, 2017
…il spec" This reverts commit 7cf71e7.
sephirothkod
added a commit
to UVicLibrary/Vault
that referenced
this pull request
Jul 13, 2017
…il spec" This reverts commit 7cf71e7.
sephirothkod
added a commit
to UVicLibrary/Vault
that referenced
this pull request
Jul 13, 2017
… thumbnail spec"" This reverts commit 6e8af9c.
alishaevn
pushed a commit
to rkuehn-uofl/hyku
that referenced
this pull request
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This override was here in the first place because the default
implementation of to_param in ActiveModel requires the object to
be persisted.
We should fix this upstream:
samvera/active_fedora#1251