Bugfix for fiducial circuit line labels #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This forces each candidate fiducial to have line labels that match the state space labels for the target model. Suboptimal fix for many-qubit systems, but should be fine for 99% of use cases with ExplicitOpModels in the few-qubit setting.
sserita
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick bugfix for issue #396. The fix here is to simply force each of the line labels for candidate fiducial circuits to match the state space labels of the input target model. This is a suboptimal fix looking forward to many-qubit systems (as I mentioned in a comment on #396), but we don't presently have the infrastructure needed for doing this a better way and this fix should be fine for 99% of use cases with ExplicitOpModels in the few-qubit setting.