Bugfix 0.9.12.2 #421
Bugfix 0.9.12.2 #421
Conversation
Fixes minor error in docstring.
sserita
requested review from
adhumu and
coreyostrove
and removed request for
adhumu
Add a fix for an error with color box plot generation caught by the extended unit tests due to some unhandled cases when calling the color box plot function with pre-specified/user-generated sub-matrix data.
|
Piggybacking on this PR with a bugfix for some reporting code I broke with PR #415 which got caught by the extra tests on beta. |
There was a problem hiding this comment.
These changes all look good to me. Great work.
There was a problem hiding this comment.
Thanks for implementing this fix!
There was a problem hiding this comment.
Great work! This is where I admit to having spent around 45 minutes today trying to implement something similar, but failing on account of quite literally never having written a line of javascript once in my life. Glad to know you're familiar with javascript coding.
There was a problem hiding this comment.
Really had to dust off my JS/HTML/CSS for this, it was my first coding job back when I was a tween 😅
|
Everything looks good to me for the changes that you had made. There is a substantive changed I pushed piggybacking onto this PR. Whenever you get a chance if you could review that (and assuming there aren't any issues therein) then I think this is good to go. |
There was a problem hiding this comment.
Really had to dust off my JS/HTML/CSS for this, it was my first coding job back when I was a tween 😅
This PR contains three minor bugfixes slated for 0.9.12.2:
The leakage notebook may not be in a completely finished state. These updates are more or less making it so that circuit line labels are explicit, but it's a little awkward/still not working completely, especially for the kite structure example at the bottom. Suggestion now are welcome, or we can just slate it reworking later.