Fix a few issues uncovered during full Chapel testing of qthreads 1.12 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 04dee4e. Revert adding all of 'alloc/' to EXTRA_DIST in favor of adding the individual allocators.
Same intent as 04dee4e, but adds individual files to avoid adding .deps to the release tarball (also follows existing pattern for adding things to EXTRA_DIST)
Bring in qthread-int.h for uint_fast16_t. CHPL_MEM=jemalloc happened to bring
in uint_fast16_t, but CHPL_MEM=cstdlib doesn't, so compilation was failing.
Longer term, I think it'd be nice to switch alignment from a uint_fast16_t to
size_t and change the signature to match the standard memalign or aligned_alloc
routines.
i.e. change:
void *qt_internal_aligned_alloc(size_t alloc_size, uint_fast16_t alignment)
void qt_internal_aligned_free(void *ptr, uint_fast16_t alignment)
to
void *qt_aligned_alloc(size_t alignment, size_t size)
void qt_aligned_free(void *ptr, size_t alignment)
Quiet "‘visibility’ attribute ignored on non-class types" warnings for qthread_tos() and qthread_bos(). I think this change should be made for all functions, but these are the only ones that currently produce the warning. See #50 for more info
ronawho
added a commit
to ronawho/chapel
that referenced
this pull request
Mar 12, 2017
uint_fast16_t was undefined under cstdlib, so bring in qthread-int.h. Also quiet a visibility attribute warning. I've opened a PR with these changes upstream, so hopefully we can get these in an official 1.12 release soon: sandialabs/qthreads#51
ronawho
added a commit
to chapel-lang/chapel
that referenced
this pull request
Mar 12, 2017
Fix qthreads --with-alloc=chapel for CHPL_MEM=cstdlib uint_fast16_t was undefined under cstdlib, so bring in qthread-int.h. Also quiet a visibility attribute warning. I've opened a PR with these changes upstream, so hopefully we can get these in an official 1.12 release soon: sandialabs/qthreads#51
|
@npe9 if you're ok with these changes, would you mind merging them and cutting a fresh 1.12 release with them included? |
|
Sure, I'd be happy to. |
|
I pushed a new tarball and updated the tag on the release. If there's anything broken/odd please don't hesitate to tell me. |
|
Cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual commits have more detail