-
Notifications
You must be signed in to change notification settings - Fork 1
Final tweaks #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Final tweaks #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 180 180
Branches 21 21
=========================================
Hits 180 180 ☔ View full report in Codecov by Sentry. |
9c24d80
to
54fd6e2
Compare
According to PEP 561, we need to add this file to static type checkers can infer the types from the package.
Add templates for the release notes and `CHANGELOG` so `python-semantic-release` can generate these files correctly in CI.
Add a blank requirements file for the examples to facilitate adding requirements in the future.
Add a dummy CHANGELOG.md to be overwritten by Semantic Release.
When running `ruff` via pre-commit, don't automatically fix the problems; instead tell the user what's wrong to train them into not making the problems in the first place.
5ba938d
to
9cb978a
Compare
Closed
5b85053
to
28c1854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final tweaks while finishing up the open sourcing of this package.
Commits
ci: Check documentation spelling and coverage (e5b3719)
patch: Indicate that the package is typed (55a20c9)
According to PEP 561, we need to add this file to static type checkers can infer the types from the package.
ci: Add semantic release templates (0cb13c1)
Add templates for the release notes and
CHANGELOG
sopython-semantic-release
can generate these files correctly in CI.chore: Add example requirements (343b8e7)
Add a blank requirements file for the examples to facilitate adding requirements in the future.
chore: Add CHANGELOG (c5ce0f4)
Add a dummy CHANGELOG.md to be overwritten by Semantic Release.
docs: Slight tweaks to contributing guidelines (59325de)
ci: Omit
--fix
arg (2207516)When running
ruff
via pre-commit, don't automatically fix the problems; instead tell the user what's wrong to train them into not making the problems in the first place.test: Run the examples and check their output (ccfa0d9)