meteor add typescript
#3242
Merged
meteor add typescript
#3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes meteor to automatically compile .ts an .tsx source files into javascript for us. From here we can start converting single files over to typescript, or add new files with a .ts extension.
Mostly to make sure the meteor package actually works (it does). This is just a pile of imports, so it's an easy case, as there's no code to update.
|
Huh, build is failing. I'll investigate further. |
I'd tried `dev-shell` to make sure typescript was building correctly, but this didn't get updated.
|
Is this working then at this point? |
|
Yeah, the last commit I pushed fixed the build. This is good to go. |
|
yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards starting to use typescript. This adds the meteor package, which causes the meteor build system to compile
.tsand.tsxextensions to javascript. I also renamed a couple trivial files to make sure doing so doesn't break anything.From here we can convert old code at our leisure, and write new code in typescript where convenient.