Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor add typescript #3242

Merged
merged 4 commits into from
Mar 16, 2020
Merged

meteor add typescript #3242

merged 4 commits into from
Mar 16, 2020

Conversation

zenhack
Copy link
Collaborator

@zenhack zenhack commented Feb 23, 2020

First step towards starting to use typescript. This adds the meteor package, which causes the meteor build system to compile .ts and .tsx extensions to javascript. I also renamed a couple trivial files to make sure doing so doesn't break anything.

From here we can convert old code at our leisure, and write new code in typescript where convenient.

This causes meteor to automatically compile .ts an .tsx source files
into javascript for us. From here we can start converting single files
over to typescript, or add new files with a .ts extension.
Mostly to make sure the meteor package actually works (it does). This is
just a pile of imports, so it's an easy case, as there's no code to
update.
@zenhack
Copy link
Collaborator Author

zenhack commented Feb 23, 2020

Huh, build is failing. I'll investigate further.

I'd tried `dev-shell` to make sure typescript was building correctly,
but this didn't get updated.
@ocdtrekkie
Copy link
Collaborator

Is this working then at this point?

@zenhack
Copy link
Collaborator Author

zenhack commented Feb 29, 2020

Yeah, the last commit I pushed fixed the build. This is good to go.

@ocdtrekkie ocdtrekkie added the ready-for-review We think this is ready for review label Feb 29, 2020
@kentonv
Copy link
Member

kentonv commented Mar 16, 2020

yay!

@kentonv kentonv merged commit 2131dcb into sandstorm-io:master Mar 16, 2020
@ocdtrekkie ocdtrekkie removed the ready-for-review We think this is ready for review label Mar 16, 2020
@zenhack zenhack deleted the typescript branch December 28, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants