Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling back adding retention instructions to sample table #657

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

dasunpubudumal
Copy link
Contributor

@dasunpubudumal dasunpubudumal commented Aug 6, 2024

Closes #633

Changes proposed in this pull request

  • Removing adding the retention_instruction column in sample table.

This migration has already been applied in UAT warehouse. We can introduce a remove_column migration but that will cause problems when the two migrations add_column and remove_column goes into production as add_column in sample table is a huge task (as it is ~4Gi in size).

So the suggested change rollbacks the changes done for adding retention instructions to sample table, so that it will have no effect on the sample table in production. The migration added to UAT database is to be manually removed.

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@dasunpubudumal dasunpubudumal linked an issue Aug 6, 2024 that may be closed by this pull request
1 task
@dasunpubudumal dasunpubudumal merged commit 7c5917d into develop Aug 6, 2024
4 checks passed
@dasunpubudumal dasunpubudumal deleted the rolling-back-adding-retention-instructions branch August 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y24-162 - Record retention instructions for each sample when received
2 participants