feat: support signed urls #85
Open
+1,051
−1,334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1d5caee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
15b38f9 to
e023476
Compare
rdunk
force-pushed
the
08-29-refactor_migrate_to_esm_use_pkg-utils_for_build_switch_tests_to_vitest
branch
from
05bed0c to
e0fdb42
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
e023476 to
463af15
Compare
rdunk
force-pushed
the
08-29-refactor_migrate_to_esm_use_pkg-utils_for_build_switch_tests_to_vitest
branch
from
e0fdb42 to
d2aec21
Compare
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
463af15 to
cacea62
Compare
|
Moving to draft until |
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
2 times, most recently
from
7bac3b9 to
ab747dc
Compare
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
3 times, most recently
from
35b44c3 to
3654954
Compare
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
3654954 to
d5b6cc8
Compare
rdunk
force-pushed
the
08-29-refactor_migrate_to_esm_use_pkg-utils_for_build_switch_tests_to_vitest
branch
from
f80b5ba to
826e441
Compare
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
3 times, most recently
from
2cd545d to
5ab286b
Compare
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
5ab286b to
dd6faa1
Compare
|
Blocked by sanity-io/signed-urls#23 |
rdunk
force-pushed
the
08-29-feat_support_signed_urls
branch
from
dd6faa1 to
1d5caee
Compare
|
sanity-io/signed-urls#23 merged with an upstream fix, so this one is ready now. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Media Library introduces the concept of Protected assets, which can only be accessed via an authenticated session or signed URLs. To support Protected assets in user applications, we need to provide tooling to simplify the DX for actually generating signed URLs.
This package currently ships with no dependencies, however we now require some small crypto dependencies to handle generating signatures. As this feature will only be used by a small subset of users, and to avoid adding extraneous dependencies to user bundles, it seemed to make sense to provide an extended image URL builder with some extra signing specific methods at a different export path.
These extra methods are:
expiry - for defining an expirysigningKey - for providing a key ID and private keysignedUrl - for generating a signed URL withexpiry (optional),keyid andsignature params.The extended builder still exposes the
url method, which will omit any signing specific parameters even if they have been provided.To facilitate this, I refactored the ImageUrlBuilder class slightly to better support extending it.
I’ve also added tests to cover the new functionality.