EDX-1352: batch select sheet list documents #6713

jordanl17 · 2024-05-17T14:48:41Z

Description

EDX-1352: allowing multiselection of rows using shift+click

What to review

The dir structure has been changed so that all sheetList components and files are inside a separated dir within documentList and EX has been added a code owner.

Testing

Tests have been added to the row selection component - DocumentSheetListSelect to test around shift click functionality

Notes for release

No relevant notes as this feature is not currently exposed to users

…anes

* fix(studio): adding tooltip to read-only bool inputs * fix(studio): testing for tooltip on boolean read-only inputs * fix(studio): removing memoisation as it was useless

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

* feat: add canHandleIntent to S.component * fix: properly type canHandleIntent * Update packages/sanity/src/structure/structureBuilder/Component.ts Co-authored-by: Ash <ash@sanity.io> --------- Co-authored-by: Ash <ash@sanity.io>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(vision): add download as json/csv buttons * fix(vision): use blob urls for downloads (#6213) * fix(vision): use Translate component to avoid splitting i18n strings * fix(vision): clean up i18n resources for result saving feature --------- Co-authored-by: Espen Hovlandsdal <espen@hovlandsdal.com>

… editing form (#6610) This will prevent any input calling element.onFocus() on any opened block or inline-object inside the PT-input, as that will close the editing modal for them (through DocumentPaneProvider)

* feat(structure): Rendering sheet list layout option in test-studio * feat(structure): branching the rendering of different document list panes * feat(structure): renaming of generic pane components * feat(structure): fixing typing for new sheetList * feat(structure): resolving a default export to named * feat(structure): testing sheet view pane display logcic * fix(structure): resolving testing for useStructureTool

* test(core): add tests for document list sort and display * test(structure): add test for inspect dialog * test(core): add tests for saved searches

* test(core): fixes flaky test with document publish * test(core): use more realistic fix for flaky test

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency styled-components to ^6.1.10 * chore: update test snapshot --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <stipsan@gmail.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…6584) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

jtpetty · 2024-05-21T12:52:44Z

...sanity/src/structure/panes/documentList/sheetList/__tests__/DocumentSheetListSelect.test.tsx

+    expect(selectProps.table.options.meta?.setSelectedAnchor).toHaveBeenCalledWith(null)
+  })
+
+  it('disables the checkbox when row is not selectable', () => {


what's the reason that a row is not selectable? For a11y, it would be best to not have elements disabled.

Oh totally! Currently there is no reason why a row would be selected, but tanstack table does support this functionality, so I thought I'd add a theoretical test case to ensure that any future disabling. In the future we mihgt disable, perhaps whilst we are running a batch publish and don't want the user change row selection. Added here so it's already tested

jtpetty · 2024-05-21T12:53:59Z

packages/sanity/src/structure/panes/documentList/sheetList/useDocumentSheetColumns.tsx

+              indeterminate={info.table.getIsSomeRowsSelected()}
+              onChange={info.table.getToggleAllPageRowsSelectedHandler()}
+            />
+            {/* eslint-disable-next-line i18next/no-literal-string */}


I wonder if selected should be added to the attribute exceptions list

This was just some text I'm printing to the DOM so we can make sure that the correct rows are being selected. It's quite likely this would be deleted when we start improving styling

jtpetty

a few minor questions, but 👍 LGTM

pedrobonamin

Thanks Jordan, looks good to me. Let's have it merged after the release

ninaandal · 2024-05-22T08:14:12Z

packages/sanity/src/structure/panes/documentList/sheetList/ColumnsControl.tsx

We should be using the StudioUI components here as well, right?

The presentation of this component is just placeholder for now since we are still awaiting designs

jordanl17 and others added 30 commits May 7, 2024 11:54

feat(structure): Rendering sheet list layout option in test-studio

7a8b041

feat(structure): branching the rendering of different document list p…

b6f4ec8

…anes

feat(structure): renaming of generic pane components

a44787f

Merge branch 'next' into EDX-1283-sheet-list-menu-option

d45fc8e

feat(structure): fixing typing for new sheetList

f27eca3

fix(studio): adding tooltip to read-only bool inputs (#6580)

a5cd98c

* fix(studio): adding tooltip to read-only bool inputs * fix(studio): testing for tooltip on boolean read-only inputs * fix(studio): removing memoisation as it was useless

chore(deps): dedupe pnpm-lock.yaml (#6607)

46d3605

Co-authored-by: juice49 <1454914+juice49@users.noreply.github.com>

{wip} saved 2024-05-8 16:18

e9cfa68

fix(structure): use case insensitive search for inspect dialog (#6588)

8c4d49d

test(core): await publish action to prevent test flakiness (#6609)

46cf0d3

fix(deps): update dependency get-it to ^8.4.29 (#6603)

b912091

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(deps): update dependency @sanity/client to ^6.18.0 (#6604)

f82f900

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix(core/form): prevent onFocus for root object paths being called by…

80b4715

… editing form (#6610) This will prevent any input calling element.onFocus() on any opened block or inline-object inside the PT-input, as that will close the editing modal for them (through DocumentPaneProvider)

feat(core): add useEditStateList hook

1fdae88

feat(sheet-list): add table view

28826b3

feat(structure): rendering columns in sheet list

bf1082c

Merge branch 'edx-1284' into EDX-1308

e5d79f3

Merge branch 'edx-1284' into EDX-1308

90a4796

test(core, desk): add tests for keyvalue storage (#6587)

170a59c

* test(core): add tests for document list sort and display * test(structure): add test for inspect dialog * test(core): add tests for saved searches

v3.41.0

d73f980

test(core): fixes flaky test with document publish (#6595)

5709712

* test(core): fixes flaky test with document publish * test(core): use more realistic fix for flaky test

chore(deps): update linters (#6590)

44f4dbe

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(lockfile): update dependency zod to v3.23.7 (#6527)

399d0d8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency @sanity/pkg-utils to v6.8.13 (#6599)

60c965e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update dependency @sanity/tsdoc to v1.0.51 (#6600)

66393eb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(lockfile): update dependency @sanity/react-loader to v1.9.17 (#…

4a6d6f3

…6584) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

vercel bot deployed to Preview – test-studio May 21, 2024 09:48 View deployment

vercel bot deployed to Preview – test-next-studio May 21, 2024 09:49 View deployment

Merge branch 'next' into exploring-shift-select-sheet-list

8afe637

vercel bot had a problem deploying to Preview – performance-studio May 21, 2024 09:58 Failure

vercel bot had a problem deploying to Preview – test-studio May 21, 2024 09:58 Failure

vercel bot had a problem deploying to Preview – test-next-studio May 21, 2024 09:58 Failure

feat(structure): fixing type issue

dfdda97

vercel bot deployed to Preview – performance-studio May 21, 2024 10:15 View deployment

vercel bot deployed to Preview – test-studio May 21, 2024 10:16 View deployment

vercel bot deployed to Preview – test-next-studio May 21, 2024 10:17 View deployment

feat(structure): rename of options.meta fnc

0bc8c2b

vercel bot deployed to Preview – performance-studio May 21, 2024 10:50 View deployment

vercel bot deployed to Preview – test-studio May 21, 2024 10:51 View deployment

vercel bot deployed to Preview – test-next-studio May 21, 2024 10:52 View deployment

jordanl17 marked this pull request as ready for review May 21, 2024 12:02

jordanl17 requested review from a team as code owners May 21, 2024 12:02

jordanl17 requested review from jtpetty and pedrobonamin and removed request for a team May 21, 2024 12:02

jtpetty reviewed May 21, 2024

View reviewed changes

jtpetty approved these changes May 21, 2024

View reviewed changes

pedrobonamin approved these changes May 21, 2024

View reviewed changes

ninaandal reviewed May 22, 2024

View reviewed changes

jordanl17 added this pull request to the merge queue May 22, 2024

Merged via the queue into next with commit 10b596a May 22, 2024
39 checks passed

jordanl17 deleted the exploring-shift-select-sheet-list branch May 22, 2024 09:19

leocabrallce mentioned this pull request Jun 20, 2024

[Snyk] Upgrade sanity from 3.43.0 to 3.44.0 leocabrallce/portfolio-next#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EDX-1352: batch select sheet list documents #6713

EDX-1352: batch select sheet list documents #6713

jordanl17 commented May 17, 2024 •

edited

jtpetty May 21, 2024

jordanl17 May 21, 2024

jtpetty May 21, 2024

jordanl17 May 21, 2024

jtpetty left a comment

pedrobonamin left a comment

ninaandal May 22, 2024

jordanl17 May 22, 2024

EDX-1352: batch select sheet list documents #6713

EDX-1352: batch select sheet list documents #6713

Conversation

jordanl17 commented May 17, 2024 • edited

Description

What to review

Testing

Notes for release

jtpetty May 21, 2024

Choose a reason for hiding this comment

jordanl17 May 21, 2024

Choose a reason for hiding this comment

jtpetty May 21, 2024

Choose a reason for hiding this comment

jordanl17 May 21, 2024

Choose a reason for hiding this comment

jtpetty left a comment

Choose a reason for hiding this comment

pedrobonamin left a comment

Choose a reason for hiding this comment

ninaandal May 22, 2024

Choose a reason for hiding this comment

jordanl17 May 22, 2024

Choose a reason for hiding this comment

jordanl17 commented May 17, 2024 •

edited