feat(sanity): add telemetry for versions #7460
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 4, 2024 11:20 AM (UTC) ✅ All Tests Passed -- expand for details
|
| @@ -328,6 +328,10 @@ export const DocumentPaneProvider = memo((props: DocumentPaneProviderProps) => { | |||
| }) | |||
|
|
|||
| patchRef.current = (event: PatchEvent) => { | |||
| // when creating a new draft | |||
| if (!editState.draft && !editState.published && !editState.version) { | |||
There was a problem hiding this comment.
The first section !editState.draft && !editState.published is going to disappear because it's being pushed to next #7459
RitaDias
requested review from
cngonzalez and
a team
and removed request for
a team and
cngonzalez
| @@ -56,6 +59,9 @@ export function BundleDetailsDialog(props: BundleDetailsDialogProps): JSX.Elemen | |||
| await submit(submitValue) | |||
| if (formAction === 'create') { | |||
| setPerspective(value._id) | |||
| telemetry.log(CreatedRelease) | |||
There was a problem hiding this comment.
A thought here, though I'm unsure if this does or doesn't align with our current telemetry strategies elsewhere. But interested in your thoughts - tracking how/where a release is created eg. from the global perspective menu or from within the releases plugin
There was a problem hiding this comment.
That's true that might be interesting to know 💡
I'll add it! Thank you for the idea Jordan, great catch!
There was a problem hiding this comment.
Added it on 64bf480
I kept the terms as origin: 'structure' | 'release-plugin' because we know that the section where we create releases from the structure tool will likely change where it is (and might not end up in the nav bar as is now) and kept the name simple as release-plugin because I don't think we'll have multiple places where we'll be able to create the release within the plugin (nor do I know if we need that sort of granularity) + with the re-design it might not be in the "overview" :)
Thoughts are welcome!
|
Added @sanity-io/growth as reviewers, having their early feedback will be appreciated |
packages/sanity/src/core/bundles/components/dialog/BundleDetailsDialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for going through this and adding all the details. Great work @RitaDias !
I think we can merge it to Corel so it doesn't get merge conflicts later and in the meanwhile share it with growth to get their eyes. But not necessary to wait for their approval to merge it to Corel
* fix(sanity): issue where the createVersionSuccess was never resolving * feat(sanity): add telemetry when adding version * refactor(sanity): rename bundles to releases telemetry * feat(sanity): add telemetry when creating release * feat(sanity): add telemetry when updating release * feat(sanity): add telemetry when deleting release * feat(sanity): add telemetry when publishing release * feat(sanity): add telemetry when archive and unarchive release * chore(sanity): fix dependencies * feat(sanity): add telemetry when creating a draft * refactor(sanity): add telemetry for tracking drafts and include version * refactor(sanity): update telemetry request for creating release * refactor(sanity): reuse interface for OriginInfo * docs(sanity): clarify unarchive / archive telemetry track
* fix(sanity): issue where the createVersionSuccess was never resolving * feat(sanity): add telemetry when adding version * refactor(sanity): rename bundles to releases telemetry * feat(sanity): add telemetry when creating release * feat(sanity): add telemetry when updating release * feat(sanity): add telemetry when deleting release * feat(sanity): add telemetry when publishing release * feat(sanity): add telemetry when archive and unarchive release * chore(sanity): fix dependencies * feat(sanity): add telemetry when creating a draft * refactor(sanity): add telemetry for tracking drafts and include version * refactor(sanity): update telemetry request for creating release * refactor(sanity): reuse interface for OriginInfo * docs(sanity): clarify unarchive / archive telemetry track
* fix(sanity): issue where the createVersionSuccess was never resolving * feat(sanity): add telemetry when adding version * refactor(sanity): rename bundles to releases telemetry * feat(sanity): add telemetry when creating release * feat(sanity): add telemetry when updating release * feat(sanity): add telemetry when deleting release * feat(sanity): add telemetry when publishing release * feat(sanity): add telemetry when archive and unarchive release * chore(sanity): fix dependencies * feat(sanity): add telemetry when creating a draft * refactor(sanity): add telemetry for tracking drafts and include version * refactor(sanity): update telemetry request for creating release * refactor(sanity): reuse interface for OriginInfo * docs(sanity): clarify unarchive / archive telemetry track
Description
Added telemetry to the following actions + fixed issue when adding a version to release made the code that came after the createVersionSuccess not run (wrong id was being passed)
Bundle
Version
Draft
Out of scope (separate stories have been created):
What to review
Does this make sense? Should the messages be different?