Advanced diplotype clustering - investigate CNV imshow weirdness #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sanjaynagi, I did some digging into the CNV imshow weirdness. In this PR I stripped back the
_plot_dendro_cnv_bar()
method to the simplest possible implementation. I then tested it in thespike_dipclust_cnv
notebook, outputting both the final figure and the CNV subplot.What's weird is that the CNV subplot respects the
color_continuous_scale
parameter and thezmin
andzmax
parameters, but in the final combined figure these are ignored, meaning that the default PuOr colorscale is always used, and the zmin and zmax are always obtained from the data.I think this has to be something to do with the way that the subplots are combined into a single figure within the
concat_subplots()
method. Something about this is erasing some of the parameters originally given to imshow.That's as far as I've got for now, hope it's useful :)