Skip to content

Automate Telegram #160 #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2020
Merged

Automate Telegram #160 #208

merged 5 commits into from
Oct 31, 2020

Conversation

Namyalg
Copy link
Contributor

@Namyalg Namyalg commented Oct 29, 2020

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #160

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!

tejan-singh
tejan-singh requested changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@tejan-singh tejan-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have sent two scripts in same request. Please send them seperately.

@Namyalg
Copy link
Contributor Author

Namyalg commented Oct 31, 2020

I am unable to identify the script other than the one for Telegram Automation, can you please point it out @tejan-singh

tejan-singh
tejan-singh requested changes Oct 31, 2020
View reviewed changes
Python/Location-based-on-IP/get.py Outdated
@@ -0,0 +1,13 @@
from modulefinder import ModuleFinder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different issues I guess.

Python/Location-based-on-IP/get.py Outdated
from modulefinder import ModuleFinder

finder = ModuleFinder()
finder.run_script('get_coordinates.py')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also different issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove that folder, thanks for the assistance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the files

@tejan-singh tejan-singh merged commit 1b2475e into sanscript-tech:main Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejan-singh tejan-singh tejan-singh requested changes

Assignees
No one assigned
Labels
Change requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Namyalg @tejan-singh