Skip to content

Conversation

japneetkaurbhatia
Copy link
Contributor

@japneetkaurbhatia japneetkaurbhatia commented Nov 7, 2020

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #255

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!

@japneetkaurbhatia
Copy link
Contributor Author

Sorry but I am learning git that why I don't know how to squash commit that's why I created a new pull request.

@SANKET7738
Copy link
Contributor

@japneetbhatia still 2 commits. No hurry you can learn how to use git and squash commits and then make the PR. take your time and do it perfectly.

@japneetkaurbhatia
Copy link
Contributor Author

@SANKET7738 2 commits are due to 2 files( 1 readme, 1 script)

@tejan-singh tejan-singh merged commit aefcc3a into sanscript-tech:main Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants