Skip to content

extract files from zip in python #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2020
Merged

extract files from zip in python #363

merged 4 commits into from
Nov 17, 2020

Conversation

Sapna2001
Copy link
Contributor

@Sapna2001 Sapna2001 commented Nov 13, 2020

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #347

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!

@@ -0,0 +1,14 @@
#import pyshorteners library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain to me the use of this file here? @Sapna2001

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this script from a zip file to show an example. I will remove it.

@@ -0,0 +1,14 @@
#import pyshorteners library
import pyshorteners

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove this URL shortener script from this pr.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

# Enter the name of zip file
zipFile = input("Enter zip file:")
# Enter the path of the file to be extracted
extractFile = input("Enter path of the file:")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can take any one input from user. Either file name or path. are both really required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes.

@tejan-singh tejan-singh merged commit ffbdd82 into sanscript-tech:main Nov 17, 2020
@Sapna2001 Sapna2001 deleted the extract branch November 17, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants