Change boot methods to match Eloquent boot[traitName] pattern. #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because methods of traits used by the one class cannot have the same name there is a chance that(especially in User model) when using some other trait, it also implements
boot
method.To avoid that I changed all
boot
methods to match Laravel Eloquent boot[traitName] pattern.It is automatically resolved so it acts exactly like a
boot
method. Also, you don't need to callparent::boot
(actually you mustn't because it will crash everything) and most importantly it keeps you safe from method name conflicts.I think this issue was raised in
Zizaco/Entrust
package but never addressed, so I'm doing this here.I also added
composer.lock
file to.gitignore
because who needs it.Really looking forward to working with your fork.