Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Invoke-Parallel not disposing Runspaces #36

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

santisq
Copy link
Owner

@santisq santisq commented Jun 26, 2024

This PR fixes the issue where the cmdlet would not be correctly disposing runspaces in scenarios where a PipelineStoppedException was thrown (CTRL+C / Select-Object -First) and OperationCanceledException (Timeout reached).

@santisq santisq added the bug Something isn't working label Jun 26, 2024
@santisq santisq self-assigned this Jun 26, 2024
@santisq santisq linked an issue Jun 26, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (8fe77ca) to head (0edd1a7).

Current head 0edd1a7 differs from pull request most recent head 8b3cfb4

Please upload reports for the commit 8b3cfb4 to get more accurate results.

Files Patch % Lines
src/PSParallelPipeline/RunspacePool.cs 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   92.27%   92.16%   -0.12%     
==========================================
  Files          10       10              
  Lines         531      536       +5     
  Branches       38       39       +1     
==========================================
+ Hits          490      494       +4     
  Misses         33       33              
- Partials        8        9       +1     
Flag Coverage Δ
PS-5.1 88.51% <94.44%> (-3.29%) ⬇️
PS-7_Linux 91.79% <94.44%> (-0.49%) ⬇️
PS-7_Windows 92.11% <94.44%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisq santisq merged commit 3bff059 into main Jun 26, 2024
5 checks passed
@santisq santisq deleted the 35-invoke-parallel-not-correctly-disposing-runspaces branch June 26, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-Parallel not correctly disposing Runspaces
1 participant