Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_hana_install: Use FQCN module names only #68

Closed
berndfinger opened this issue Feb 21, 2022 · 1 comment
Closed

sap_hana_install: Use FQCN module names only #68

berndfinger opened this issue Feb 21, 2022 · 1 comment
Assignees
@berndfinger
Labels
enhancement New feature or request

Comments

@berndfinger
Copy link
Member

As per recommendation in recent Ansible module documentation, we should better rename all module names in roles to fully qualified collection names (FQCN).
@berndfinger berndfinger added the enhancement New feature or request label Feb 21, 2022
@berndfinger berndfinger self-assigned this Feb 21, 2022
berndfinger pushed a commit to berndfinger/community.sap_install that referenced this issue Feb 21, 2022
sap_hana_install: Rewrite checksum verification
abfadc2 
With this commit, the checksums of SAPCAR EXE files are verified even
before the version detection. Also, the checksum verification now
supports a central checksum file.
Relates to: sap-linuxlab#67

Additional tags have been added to allow further limitation of the
activities performed by the role. This is now the list of supported
tags:
- sap_hana_install_hdblcm_commandline
- sap_hana_install_preinstall
- sap_hana_install_prepare_sapcar
- sap_hana_install_prepare_sarfiles
- sap_hana_install_chown_hana_directories (mainly to be used with
  --skip-tags when using tag sap_hana_install_preinstall)
- sap_hana_install_extract_sarfiles (mainly to be used with
  --skip-tags when using tag sap_hana_install_prepare_sarfiles)
Relates to: sap-linuxlab#58

Files created by the template module should have a note at the top
indicating that this file should not be manually modified.
Relates to: sap-linuxlab#66

Also all Ansible modules have been renamed to FQCN.
Relates to: sap-linuxlab#68
@berndfinger berndfinger mentioned this issue Feb 21, 2022
Merged
@berndfinger
Copy link
Member Author

Solved in #69 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndfinger