Skip to content

Use new go-bits functions, streamline error handling #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2022
Merged

Use new go-bits functions, streamline error handling #40

merged 3 commits into from
Jul 13, 2022

Conversation

SuperSandro2000
Copy link
Member

No description provided.

@SuperSandro2000 SuperSandro2000 requested a review from majewsky July 11, 2022 15:11
@SuperSandro2000
Copy link
Member Author

@majewsky fixed lint check

majewsky
majewsky approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@majewsky majewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added another fix and some simplifications on top of this branch. Please merge the PR after reviewing those in turn.

@SuperSandro2000
Copy link
Member Author

checked locally and the generated file is the same

@SuperSandro2000 SuperSandro2000 merged commit 7758266 into main Jul 13, 2022
@SuperSandro2000 SuperSandro2000 deleted the go-bits branch July 13, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperSandro2000 @majewsky