-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RANSAC consumes too much RAM #17
Labels
Comments
looking forward to a PR, I hope this would not slow down RANSAC too much 👍 |
Im kind of academically compromised right now. I could do a pull request with the code as is, the problem is that is has no explanation. Or maybe by the time @adam2392 is available I will be more available too. |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have been testing pyprep against our datasets (GRUNECO, University of Antioquia, Colombia). For example I have 58 channels @ 1000Hz for about 5 minutes. This will need like 10 gb of RAM awarded from the OS to python. This is quite a lot for personal computers.
I have two possible proposals to solve this:
I like more the first proposal and @sappelhoff agrees with this approach. This was discussed in #9 .
Once #9 detrend_correction is merged into master I will upload this code so it may be reviewed and tested. It considerably changes find_bad_by_ransac() and a tiny change in run_ransac()
The text was updated successfully, but these errors were encountered: