Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove index from preconditions folder #369

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

favna
Copy link
Member

@favna favna commented Jan 24, 2022

This was causing index to be loaded many times over.

To preserve the same names of the top level exports of
CorePreconditions.UserPermissionsPreconditionContext and CorePreconditions.CooldownContext
I had to rename them internally because otherwise they reference themselves.
I tried to import them with as ... but that doesn't work because of our type bundling step.

This is what I got when adding loggers for onLoad and onUnload:

For store preconditions loading piece ClientPermissions
For store preconditions loading piece Cooldown
For store preconditions loading piece DMOnly
For store preconditions loading piece Enabled
For store preconditions loading piece GuildNewsOnly
For store preconditions loading piece GuildNewsThreadOnly
For store preconditions loading piece GuildOnly
For store preconditions loading piece GuildPrivateThreadOnly
For store preconditions loading piece GuildPublicThreadOnly
For store preconditions loading piece GuildTextOnly
For store preconditions loading piece GuildThreadOnly
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece index
For store preconditions unloading piece index
For store preconditions loading piece NSFW
For store preconditions loading piece UserPermissions

This was causing `index` to be loaded many times over.

To preserve the same names of the top level exports of
`CorePreconditions.UserPermissionsPreconditionContext` and `CorePreconditions.CooldownContext`
I had to rename them internally because otherwise they reference themselves.
I tried to import them with `as ...` but that doesn't work because of our type bundling step.

```
For store preconditions loading piece ClientPermissions
For store preconditions loading piece Cooldown
For store preconditions loading piece DMOnly
For store preconditions loading piece Enabled
For store preconditions loading piece GuildNewsOnly
For store preconditions loading piece GuildNewsThreadOnly
For store preconditions loading piece GuildOnly
For store preconditions loading piece GuildPrivateThreadOnly
For store preconditions loading piece GuildPublicThreadOnly
For store preconditions loading piece GuildTextOnly
For store preconditions loading piece GuildThreadOnly
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece index
For store preconditions loading piece NSFW
For store preconditions loading piece UserPermissions
```
@favna favna self-assigned this Jan 24, 2022
src/index.ts Show resolved Hide resolved
@favna favna merged commit 92b5542 into main Jan 24, 2022
@favna favna deleted the fix/remove-index-from-precondition-folder branch January 24, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants