Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: better Args Result types #501

Merged
merged 2 commits into from
Aug 5, 2022
Merged

refactor: better Args Result types #501

merged 2 commits into from
Aug 5, 2022

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Aug 5, 2022

Fixes #225

vladfrangu
vladfrangu requested changes Aug 5, 2022
View reviewed changes
src/lib/structures/Argument.ts Outdated Show resolved Hide resolved
@kyranet @vladfrangu
Update src/lib/structures/Argument.ts
3820bc2 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@kyranet kyranet requested a review from vladfrangu August 5, 2022 09:51
@favna favna merged commit b264c3e into main Aug 5, 2022
@favna favna deleted the refactor/better-arg-typing branch August 5, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@c43721 c43721 c43721 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Typings of all Args.****Result are incorrect
4 participants
@kyranet @favna @vladfrangu @c43721