fix(Command): Do not attempt to execute application command reloading logic when a command does not have any application commands #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
requested changes
Feb 5, 2023
|
@sapphiredev pack |
|
Hey @favna, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-598 |
vladfrangu
previously approved these changes
Feb 5, 2023
favna
changed the title
…oes not have any application commands
favna
force-pushed
the
fix/command-simple-reload-for-message-commands
branch
from
60fada2
to
37ba497
Compare
|
Works great, thanks. |
vladfrangu
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in v2.5.1 the Command class did not have an overwritten
reloadmethod at all: https://github.com/sapphiredev/framework/blob/v2.5.1/src/lib/structures/Command.tsThis suggests that we didn't actually need to overwrite the reload method when the command to be reloaded doesn't have any chat input or context menu commands. To this end, after this change, whenever a command is exclusively a message command it will also exclusively call
super.reload().