Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(LoaderStrategy): overload empty methods for extensions #345

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(LoaderStrategy): overload empty methods for extensions #345

merged 1 commit into from
Nov 13, 2023

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Nov 12, 2023

Without this, extending LoaderStrategy wouldn't the extended class to have the arguments in the onLoad, onLoadAll, onUnload, and onUnloadAll methods.

@kyranet kyranet mentioned this pull request Nov 12, 2023
Merged
@favna favna merged commit 2a971d8 into main Nov 13, 2023
5 checks passed
@favna favna deleted the fix/loader-strategy/overload-methods-for-extensions branch November 13, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@favna favna favna approved these changes

Assignees
No one assigned
Labels
semver:patch typings
Projects
Sapphire
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyranet @favna @vladfrangu