Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc stitching and cleanup #15

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Doc stitching and cleanup #15

merged 11 commits into from
Apr 19, 2024

Conversation

sarnold
Copy link
Owner

@sarnold sarnold commented Mar 28, 2024

  • make sure yagrep uses new output func, cleanup readme

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
…tests

* refactor modules for updated load_config args !minor
* migrate appropriate config settings to new oscal

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* make sure text data read/write supports the same formats
* add simple consumer test script for the above

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* also apply pre-commit formatting fixes

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* add tests and cleanup code

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* update default config keys for oscal module

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* account for differences in SSG vs NIST control formats, at least
  enough for the basic ID set matching
* oscal default glob should limit the search to either resolved profiles
  only or use the catalog sources

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* add sorted output option for ssg control set match
* eliminate unnecessary variable in yasort module
* update test data and move most output to verbose only
* update project files with natsort package dep

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* add munge file arg to pass in csv data to compare and append
  a column for id set status, eg, whether ids in the input list
  are present in the csv data, and then mark the new column Y/N
* short-circuit munge file arg and feed it single column of
  control IDs

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
* allow substring match in between exact match and none
* save chk script and update default oscal.yaml

Signed-off-by: Steve Arnold <sarnold@vctlabs.com>
Copy link

Package Line Rate Branch Rate Complexity Health
src.ymltoxml 96% 95% 0
Summary 96% (356 / 370) 95% (140 / 148) 0

Copy link

Hello @sarnold! Thanks for opening this PR. We found the following information based on analysis of the coverage report:

Base Branch Rate coverage is 93%
Merging f7dbb43 into main will increase coverage by 2%

Nice work, @sarnold. Cheers! 🍻

@sarnold sarnold merged commit ecdff90 into main Apr 19, 2024
34 checks passed
@sarnold sarnold deleted the ssg-nist-controls branch August 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant